Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(autoware_obstacle_stop_planner): rework parameters #7795

Merged
merged 11 commits into from
Aug 22, 2024
Merged

refactor(autoware_obstacle_stop_planner): rework parameters #7795

merged 11 commits into from
Aug 22, 2024

Conversation

Ariiees
Copy link
Contributor

@Ariiees Ariiees commented Jul 2, 2024

Description

Implement the ROS Node configuration layout for the obstacle_stop_planner package.

Test performed

  1. Build colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to autoware_obstacle_stop_planner
  2. Launch ros2 launch autoware_obstacle_stop_planner obstacle_stop_planner.launch.xml

Notes for reviewers

None

Interface Changes

  1. Create 3 schema.json files
  2. Update README.md

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.
    After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jul 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mitsudome-r mitsudome-r mentioned this pull request Jul 4, 2024
Closed
7 tasks
@mitsudome-r mitsudome-r added run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Jul 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-7795/
Modified URLs:

@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.93%. Comparing base (60cc9c7) to head (4f548b8).
Report is 10 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7795      +/-   ##
==========================================
- Coverage   24.01%   23.93%   -0.09%     
==========================================
  Files        1384     1385       +1     
  Lines      102173   102078      -95     
  Branches    38947    38891      -56     
==========================================
- Hits        24536    24430     -106     
- Misses      75138    75172      +34     
+ Partials     2499     2476      -23
Flag Coverage Δ *Carryforward flag
differential 9.53% <ø> (?)
total 23.93% <ø> (-0.08%) ⬇️ Carriedforward from a9ecfc4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mitsudome-r
mitsudome-r reviewed Jul 4, 2024
View reviewed changes
planning/autoware_obstacle_stop_planner/schema/obstacle_stop_planner.schema.json Outdated Show resolved Hide resolved
planning/autoware_obstacle_stop_planner/schema/obstacle_stop_planner.schema.json Outdated Show resolved Hide resolved
planning/autoware_obstacle_stop_planner/schema/obstacle_stop_planner.schema.json Outdated Show resolved Hide resolved
planning/autoware_obstacle_stop_planner/schema/obstacle_stop_planner.schema.json Outdated Show resolved Hide resolved
planning/autoware_obstacle_stop_planner/schema/obstacle_stop_planner.schema.json Outdated Show resolved Hide resolved
planning/autoware_obstacle_stop_planner/schema/obstacle_stop_planner.schema.json Outdated Show resolved Hide resolved
planning/autoware_obstacle_stop_planner/schema/obstacle_stop_planner.schema.json Outdated Show resolved Hide resolved
planning/autoware_obstacle_stop_planner/schema/obstacle_stop_planner.schema.json Outdated Show resolved Hide resolved
@mitsudome-r mitsudome-r self-requested a review July 11, 2024 14:19
mitsudome-r
mitsudome-r reviewed Aug 1, 2024
View reviewed changes
Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like CI is still failing for json schema check. It seems to be due to syntax error.

@mitsudome-r mitsudome-r force-pushed the obstacle_stop_planner branch from 2b64d0c to 9a47f6f Compare August 8, 2024 14:05
@mitsudome-r
Copy link
Member

Although there are no approval from the code owner, I will be merging this PR once the CI passes since there weren't any reactions from them for over a week. This PR only affects the documentation and shouldn't affect the behavior of Autoware anyways.

@mitsudome-r mitsudome-r force-pushed the obstacle_stop_planner branch from 4cd939f to 38f866a Compare August 15, 2024 14:10
@Ariiees
Copy link
Contributor Author

Ariiees commented Aug 19, 2024

Although there are no approval from the code owner, I will be merging this PR once the CI passes since there weren't any reactions from them for over a week. This PR only affects the documentation and shouldn't affect the behavior of Autoware anyways.

Hi @mitsudome-r,

Sure! Thank you so much. I will also keep an eye on this. And make sure it sync with the main.

@mitsudome-r mitsudome-r merged commit 53f7d82 into autowarefoundation:main Aug 22, 2024
31 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
@Ariiees @kyoichi-sugahara
refactor(autoware_obstacle_stop_planner): rework parameters (autoware…
3b7fd58 
…foundation#7795)

Signed-off-by: Ariiees <[email protected]>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
@Ariiees @a-maumau
refactor(autoware_obstacle_stop_planner): rework parameters (autoware…
4d2e461 
…foundation#7795)

Signed-off-by: Ariiees <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitsudome-r mitsudome-r mitsudome-r approved these changes

@brkay54 brkay54 Awaiting requested review from brkay54

@beyzanurkaya beyzanurkaya Awaiting requested review from beyzanurkaya beyzanurkaya is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

Assignees
No one assigned
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ariiees @mitsudome-r